Proper tests #147
Open
Proper tests #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -spec tag to all function in poolboy module. Improving the readability of the description of the specification (-spec) of function parameters. Add the use of @equiv tag to increase understanding of how the function works. Add edoc, edoc_private tasks to Makefile.
Rethink EUnit tests (reproduce EUnit tests as proper tests, fixing expected state of worker pool).
Fix error:
===> Errors loading plugin {rebar3_eqc,".*",
{git,
"https://github.com/kellymclaughlin/rebar3-eqc-plugin.git",
{tag,"0.1.0"}}}. Run rebar3 with DEBUG=1 set to see errors.
Note:
poolboy_eqc.erl is not worked. I would be nice rewrite it or remove it.
Add documentation to status(Pool) function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
poolboy_eqc.erl is not worked. I would be nice rewrite it or remove it.
status(Pool)function.